]> git.ipfire.org Git - thirdparty/freeradius-server.git/commitdiff
Satisfy both clang scan and Coverity (CID #1603335)
authorNick Porter <nick@portercomputing.co.uk>
Mon, 10 Jun 2024 07:40:28 +0000 (08:40 +0100)
committerNick Porter <nick@portercomputing.co.uk>
Mon, 10 Jun 2024 07:40:28 +0000 (08:40 +0100)
src/modules/rlm_sql/rlm_sql.c

index d5e171a2308c5a6d2b89dbe0754cc07e735ea67c..03ab4ab92fd2011336a0b7074e11901bf7836c4d 100644 (file)
@@ -987,7 +987,7 @@ static unlang_action_t sql_get_grouplist_resume(rlm_rcode_t *p_result, UNUSED in
                        goto error;
                }
 
-               if (!group_ctx->groups || !entry) {     /* clang scan couldn't tell that when groups_ctx->groups != NULL then entry != NULL */
+               if (!entry) {
                        group_ctx->groups = talloc_zero(group_ctx, rlm_sql_grouplist_t);
                        entry = group_ctx->groups;
                } else {