clk: renesas: rzv2h: Add selective Runtime PM support for clocks

Update `rzv2h_cpg_attach_dev` to prevent external and core clocks not tied
to the power domain from being managed by Runtime PM. This ensures that
only clocks originating from the domain are controlled, thereby avoiding
unintended handling of external and core clocks.

Additionally, introduce a `no_pm` flag in `mod_clock` and `rzv2h_mod_clk`
structures to exclude specific clocks from Runtime PM when needed. Some
clocks, such as those in the CRU block, require unique enable/disable
sequences that are incompatible with standard Runtime PM. For example,
the CSI-2 D-PHY clock initialization requires toggling individual clocks,
making Runtime PM unsuitable.

The helper function `rzv2h_cpg_is_pm_clk()` checks whether a clock should
be managed by Runtime PM based on this `no_pm` flag. New macros, such as
`DEF_MOD_NO_PM`, allow straightforward declaration of clocks that bypass
PM.

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/20241202203916.48668-2-prabhakar.mahadev-lad.rj@bp.renesas.com
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

diff --git a/drivers/clk/renesas/rzv2h-cpg.c b/drivers/clk/renesas/rzv2h-cpg.c
index b524a9d33610f66c4c3efedd26640c9e3924c72c..1154493583a70f9c60933e4eb13da76bb10ca6bf 100644 (file)
--- a/drivers/clk/renesas/rzv2h-cpg.c
+++ b/drivers/clk/renesas/rzv2h-cpg.c
@@ -98,6 +98,7 @@ struct pll_clk {
  *
  * @priv: CPG private data
  * @hw: handle between common and hardware-specific interfaces
+ * @no_pm: flag to indicate PM is not supported
  * @on_index: register offset
  * @on_bit: ON/MON bit
  * @mon_index: monitor register offset
@@ -106,6 +107,7 @@ struct pll_clk {
 struct mod_clock {
        struct rzv2h_cpg_priv *priv;
        struct clk_hw hw;
+       bool no_pm;
        u8 on_index;
        u8 on_bit;
        s8 mon_index;
@@ -541,6 +543,7 @@ rzv2h_cpg_register_mod_clk(const struct rzv2h_mod_clk *mod,
        clock->on_bit = mod->on_bit;
        clock->mon_index = mod->mon_index;
        clock->mon_bit = mod->mon_bit;
+       clock->no_pm = mod->no_pm;
        clock->priv = priv;
        clock->hw.init = &init;
 
@@ -668,17 +671,51 @@ struct rzv2h_cpg_pd {
        struct generic_pm_domain genpd;
 };
 
+static bool rzv2h_cpg_is_pm_clk(struct rzv2h_cpg_pd *pd,
+                               const struct of_phandle_args *clkspec)
+{
+       if (clkspec->np != pd->genpd.dev.of_node || clkspec->args_count != 2)
+               return false;
+
+       switch (clkspec->args[0]) {
+       case CPG_MOD: {
+               struct rzv2h_cpg_priv *priv = pd->priv;
+               unsigned int id = clkspec->args[1];
+               struct mod_clock *clock;
+
+               if (id >= priv->num_mod_clks)
+                       return false;
+
+               if (priv->clks[priv->num_core_clks + id] == ERR_PTR(-ENOENT))
+                       return false;
+
+               clock = to_mod_clock(__clk_get_hw(priv->clks[priv->num_core_clks + id]));
+
+               return !clock->no_pm;
+       }
+
+       case CPG_CORE:
+       default:
+               return false;
+       }
+}
+
 static int rzv2h_cpg_attach_dev(struct generic_pm_domain *domain, struct device *dev)
 {
+       struct rzv2h_cpg_pd *pd = container_of(domain, struct rzv2h_cpg_pd, genpd);
        struct device_node *np = dev->of_node;
        struct of_phandle_args clkspec;
        bool once = true;
        struct clk *clk;
+       unsigned int i;
        int error;
-       int i = 0;
 
-       while (!of_parse_phandle_with_args(np, "clocks", "#clock-cells", i,
-                                          &clkspec)) {
+       for (i = 0; !of_parse_phandle_with_args(np, "clocks", "#clock-cells", i, &clkspec); i++) {
+               if (!rzv2h_cpg_is_pm_clk(pd, &clkspec)) {
+                       of_node_put(clkspec.np);
+                       continue;
+               }
+
                if (once) {
                        once = false;
                        error = pm_clk_create(dev);
@@ -700,7 +737,6 @@ static int rzv2h_cpg_attach_dev(struct generic_pm_domain *domain, struct device
                                error);
                        goto fail_put;
                }
-               i++;
        }
 
        return 0;

diff --git a/drivers/clk/renesas/rzv2h-cpg.h b/drivers/clk/renesas/rzv2h-cpg.h
index 819029c81904ec9a66a9beae04a623c3c99e858f..0723df4c113477677f8e7d94a3147ccbf662933c 100644 (file)
--- a/drivers/clk/renesas/rzv2h-cpg.h
+++ b/drivers/clk/renesas/rzv2h-cpg.h
@@ -100,6 +100,7 @@ enum clk_types {
  * @name: handle between common and hardware-specific interfaces
  * @parent: id of parent clock
  * @critical: flag to indicate the clock is critical
+ * @no_pm: flag to indicate PM is not supported
  * @on_index: control register index
  * @on_bit: ON bit
  * @mon_index: monitor register index
@@ -109,17 +110,19 @@ struct rzv2h_mod_clk {
        const char *name;
        u16 parent;
        bool critical;
+       bool no_pm;
        u8 on_index;
        u8 on_bit;
        s8 mon_index;
        u8 mon_bit;
 };
 
-#define DEF_MOD_BASE(_name, _parent, _critical, _onindex, _onbit, _monindex, _monbit) \
+#define DEF_MOD_BASE(_name, _parent, _critical, _no_pm, _onindex, _onbit, _monindex, _monbit) \
        { \
                .name = (_name), \
                .parent = (_parent), \
                .critical = (_critical), \
+               .no_pm = (_no_pm), \
                .on_index = (_onindex), \
                .on_bit = (_onbit), \
                .mon_index = (_monindex), \
@@ -127,10 +130,13 @@ struct rzv2h_mod_clk {
        }
 
 #define DEF_MOD(_name, _parent, _onindex, _onbit, _monindex, _monbit)          \
-       DEF_MOD_BASE(_name, _parent, false, _onindex, _onbit, _monindex, _monbit)
+       DEF_MOD_BASE(_name, _parent, false, false, _onindex, _onbit, _monindex, _monbit)
 
 #define DEF_MOD_CRITICAL(_name, _parent, _onindex, _onbit, _monindex, _monbit) \
-       DEF_MOD_BASE(_name, _parent, true, _onindex, _onbit, _monindex, _monbit)
+       DEF_MOD_BASE(_name, _parent, true, false, _onindex, _onbit, _monindex, _monbit)
+
+#define DEF_MOD_NO_PM(_name, _parent, _onindex, _onbit, _monindex, _monbit)            \
+       DEF_MOD_BASE(_name, _parent, false, true, _onindex, _onbit, _monindex, _monbit)
 
 /**
  * struct rzv2h_reset - Reset definitions