'closest' must be non NULL, remove test.

6412 cleanup:
6413        dns_rdataset_disassociate(&neg);
6414        dns_rdataset_disassociate(&negsig);

	CID 1452700 (#1 of 1): Dereference before null check (REVERSE_INULL)
	check_after_deref: Null-checking closest suggests that it
	may be null, but it has already been dereferenced on all
	paths leading to the check.

6415        if (closest != NULL)
6416                free_noqname(mctx, &closest);

diff --git a/lib/dns/rbtdb.c b/lib/dns/rbtdb.c
index e2c9df1cf4cf20bfe93c0405f5be8841c9c8c6cf..97c328041dfa71b55cede4f8209d20607f8180cb 100644 (file)
--- a/lib/dns/rbtdb.c
+++ b/lib/dns/rbtdb.c
@@ -6412,8 +6412,7 @@ addclosest(dns_rbtdb_t *rbtdb, rdatasetheader_t *newheader,
  cleanup:
        dns_rdataset_disassociate(&neg);
        dns_rdataset_disassociate(&negsig);
-       if (closest != NULL)
-               free_noqname(mctx, &closest);
+       free_noqname(mctx, &closest);
        return(result);
 }