]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s4:torture: Initialize struct smb_nttrans
authorAndreas Schneider <asn@samba.org>
Mon, 8 Jul 2024 09:12:02 +0000 (11:12 +0200)
committerGünther Deschner <gd@samba.org>
Tue, 16 Jul 2024 11:41:33 +0000 (11:41 +0000)
"Error: UNINIT (CWE-457):
samba-4.20.0rc2/source4/torture/basic/scanner.c:368: var_decl: Declaring variable ""parms"" without initializer.
samba-4.20.0rc2/source4/torture/basic/scanner.c:388: uninit_use_in_call: Using uninitialized value ""parms.in.setup"" when calling ""smb_raw_nttrans"".
  386|    parms.in.data = ntdata_blob;
  387|
  388|->  status = smb_raw_nttrans(cli->tree, mem_ctx, &parms);
  389|
  390|    if (NT_STATUS_IS_ERR(status)) {"

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
source4/torture/basic/scanner.c

index 567b25e788bc65139eac81c4bdaf634fe7bfe93f..335179f82bb90ff5933b8a5a1ce591582f579e59 100644 (file)
@@ -365,7 +365,7 @@ static NTSTATUS try_nttrans(struct smbcli_state *cli,
                            int param_len, int data_len,
                            int *rparam_len, int *rdata_len)
 {
-       struct smb_nttrans parms;
+       struct smb_nttrans parms = {};
        DATA_BLOB ntparam_blob, ntdata_blob;
        TALLOC_CTX *mem_ctx;
        NTSTATUS status;