]> git.ipfire.org Git - thirdparty/freeradius-server.git/commitdiff
make the error messages clearer
authorAlan T. DeKok <aland@freeradius.org>
Sun, 20 Jul 2025 13:57:42 +0000 (15:57 +0200)
committerAlan T. DeKok <aland@freeradius.org>
Sun, 20 Jul 2025 13:57:42 +0000 (15:57 +0200)
src/modules/rlm_redis/rlm_redis.c

index 31bf5bd44f26933a2fa22e6a7baf701bc673dac8..e7eb9f527c5b994fcd74e9d3d412ba625dc67d4f 100644 (file)
@@ -186,13 +186,15 @@ static ssize_t redis_xlat(void *instance, REQUEST *request, char const *fmt, cha
                break;
 
        default:
-               buffer_ptr = NULL;
-               break;
+               RDEBUG("rlm_redis (%s): Unsupported result %d from redis",
+                      inst->xlat_name, dissocket->reply->type);
+               ret = -1;
+               goto release;
        }
 
-       if ((ret >= freespace) || (!buffer_ptr)) {
-               RDEBUG("rlm_redis (%s): Can't write result, insufficient space or unsupported result\n",
-                      inst->xlat_name);
+       if (ret >= freespace) {
+               RDEBUG("rlm_redis (%s): Can't write result (%zd), insufficient space (%zd)",
+                      inst->xlat_name, ret, freespace);
                ret = -1;
                goto release;
        }