]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
ALSA: hda: Increase default bdl_pos_adj for Apollo Lake
authorRui Salvaterra <rsalvaterra@gmail.com>
Mon, 22 Jan 2024 11:45:13 +0000 (11:45 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 1 Mar 2024 12:34:50 +0000 (13:34 +0100)
[ Upstream commit 56beedc88405fd8022edfd1c2e63d1bc6c95efcb ]

Apollo Lake seems to also suffer from IRQ timing issues. After being up for ~4
minutes, a Pentium N4200 system ends up falling back to workqueue-based IRQ
handling:

[  208.019906] snd_hda_intel 0000:00:0e.0: IRQ timing workaround is activated
for card #0. Suggest a bigger bdl_pos_adj.

Unfortunately, the Baytrail and Braswell workaround value of 32 samples isn't
enough to fix the issue here. Default to 64 samples.

Signed-off-by: Rui Salvaterra <rsalvaterra@gmail.com>
Reviewed-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
Link: https://lore.kernel.org/r/20240122114512.55808-3-rsalvaterra@gmail.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/pci/hda/hda_intel.c

index 1596157556862df1f2e5ea742b000b34b61d7da9..a6a9d353fe635a834ceb66649dafe8ea91209b20 100644 (file)
@@ -1738,6 +1738,8 @@ static int default_bdl_pos_adj(struct azx *chip)
                case PCI_DEVICE_ID_INTEL_HDA_BYT:
                case PCI_DEVICE_ID_INTEL_HDA_BSW:
                        return 32;
+               case PCI_DEVICE_ID_INTEL_HDA_APL:
+                       return 64;
                }
        }