]> git.ipfire.org Git - thirdparty/wireguard-apple.git/commitdiff
SwitchCell nits
authorEric Kuck <eric@bluelinelabs.com>
Sat, 22 Dec 2018 21:32:29 +0000 (15:32 -0600)
committerEric Kuck <eric@bluelinelabs.com>
Sat, 22 Dec 2018 21:32:29 +0000 (15:32 -0600)
Signed-off-by: Eric Kuck <eric@bluelinelabs.com>
WireGuard/WireGuard/UI/iOS/View/SwitchCell.swift
WireGuard/WireGuard/UI/iOS/ViewController/TunnelEditTableViewController.swift

index 68939a7a78096fe73b87ceea1f5c3f5b16501fe3..7794e6bc613a1f11a6bd3a790319dbaad96b882f 100644 (file)
@@ -41,6 +41,7 @@ class SwitchCell: UITableViewCell {
 
     override func prepareForReuse() {
         super.prepareForReuse()
+        onSwitchToggled = nil
         isEnabled = true
         message = ""
         isOn = false
index 968f0f9a8a0edd8c51568032795ba54e6ba07618..6fc0646c019f2f510cf628fdce9e5a7d9c715284 100644 (file)
@@ -414,17 +414,16 @@ extension TunnelEditTableViewController {
                 guard let self = self else { return }
                 guard isOn != self.activateOnDemandSetting.isActivateOnDemandEnabled else { return }
 
+                self.activateOnDemandSetting.isActivateOnDemandEnabled = isOn
+                self.loadSections()
+
                 let indexPaths = (1 ..< 4).map { IndexPath(row: $0, section: indexPath.section) }
                 if isOn {
-                    self.activateOnDemandSetting.isActivateOnDemandEnabled = true
                     if self.activateOnDemandSetting.activateOnDemandOption == .none {
                         self.activateOnDemandSetting.activateOnDemandOption = TunnelViewModel.defaultActivateOnDemandOption()
                     }
-                    self.loadSections()
                     self.tableView.insertRows(at: indexPaths, with: .fade)
                 } else {
-                    self.activateOnDemandSetting.isActivateOnDemandEnabled = false
-                    self.loadSections()
                     self.tableView.deleteRows(at: indexPaths, with: .fade)
                 }
             }
@@ -435,7 +434,7 @@ extension TunnelEditTableViewController {
             let selectedOption = activateOnDemandSetting.activateOnDemandOption
             assert(selectedOption != .none)
             cell.message = TunnelViewModel.activateOnDemandOptionText(for: rowOption)
-            cell.isChecked = (selectedOption == rowOption)
+            cell.isChecked = selectedOption == rowOption
             return cell
         }
     }