]> git.ipfire.org Git - thirdparty/iproute2.git/commitdiff
qfq: fix parse_opt dead code
authorStephen Hemminger <shemming@brocade.com>
Tue, 27 Oct 2015 06:46:20 +0000 (15:46 +0900)
committerStephen Hemminger <shemming@brocade.com>
Tue, 27 Oct 2015 06:46:20 +0000 (15:46 +0900)
Fix Coverity warning from dead code.

tc/q_qfq.c

index 05b4d84e2118450d5d87d1c9fce9dd55fb1140fa..0e026749a2ef28493be726bf897e70678ec7701b 100644 (file)
@@ -38,16 +38,11 @@ static void explain_class(void)
 static int qfq_parse_opt(struct qdisc_util *qu, int argc, char **argv,
                         struct nlmsghdr *n)
 {
-       while (argc > 0) {
-               if (matches(*argv, "help") == 0) {
-                       explain();
-                       return -1;
-               } else {
+       if (argc > 0) {
+               if (matches(*argv, "help") != 0)
                        fprintf(stderr, "What is \"%s\"?\n", *argv);
-                       explain();
-                       return -1;
-               }
-               argc--; argv++;
+               explain();
+               return -1;
        }
 
        return 0;