we don't need to set vp->op

it's set by fr_pair_afrom_da()

diff --git a/src/modules/rlm_isc_dhcp/rlm_isc_dhcp.c b/src/modules/rlm_isc_dhcp/rlm_isc_dhcp.c
index a43c8e7cd74f3f252e3ffa1bb8595c4377a871ee..6e072f03ee7dbffdceb234cfc41d568a61e462b6 100644 (file)
--- a/src/modules/rlm_isc_dhcp/rlm_isc_dhcp.c
+++ b/src/modules/rlm_isc_dhcp/rlm_isc_dhcp.c
@@ -1019,8 +1019,6 @@ static int parse_option(rlm_isc_dhcp_info_t *parent, rlm_isc_dhcp_tokenizer_t *s
                return ret;
        }
 
-       vp->op = T_OP_EQ;
-
        fr_pair_append(&parent->options, vp);
 
        // @todo - print out ISC names...
@@ -1045,8 +1043,6 @@ static int parse_option(rlm_isc_dhcp_info_t *parent, rlm_isc_dhcp_tokenizer_t *s
                ret = fr_pair_value_from_str(vp, state->token, state->token_len, NULL, false);
                if (ret < 0) return ret;
 
-               vp->op = T_OP_EQ;
-
                fr_pair_append(&parent->options, vp);
 
                // @todo - print out ISC names...