]> git.ipfire.org Git - thirdparty/sqlalchemy/alembic.git/commitdiff
- get tests passing for 0.8, 0.7
authorMike Bayer <mike_mp@zzzcomputing.com>
Sat, 20 Sep 2014 18:54:37 +0000 (14:54 -0400)
committerMike Bayer <mike_mp@zzzcomputing.com>
Sat, 20 Sep 2014 18:54:37 +0000 (14:54 -0400)
alembic/autogenerate/render.py
alembic/testing/requirements.py
tests/test_autogen_render.py

index 9fe560a5c6ba19d421e95df97b54005c5d3f5f1f..7d9817a4266d957469bce88d772c315566495755 100644 (file)
@@ -92,7 +92,7 @@ def _drop_table(table, autogen_context):
 def _get_index_rendered_expressions(idx, autogen_context):
     if compat.sqla_08:
         return [repr(getattr(exp, "name", None))
-                if isinstance(exp, sql.schema.Column)
+                if isinstance(exp, sa_schema.Column)
                 else _render_potential_expr(exp, autogen_context)
                 for exp in idx.expressions]
     else:
index fbf54d7769d7d949d895ff25f6abb213d4f0e043..a52a9b2e7b68753e96c182d4fea145043d576227 100644 (file)
@@ -52,6 +52,13 @@ class SuiteRequirements(Requirements):
             "SQLAlchemy 0.8.4 or greater required"
         )
 
+    @property
+    def fail_before_sqla_09(self):
+        return exclusions.fails_if(
+            lambda config: not util.sqla_09,
+            "SQLAlchemy 0.9.0 or greater required"
+        )
+
     @property
     def sqlalchemy_08(self):
 
index c53e9e20dd0754697b93a3c30cb59268b0a2e434..fbb661f5323b9548577cd4c4bdfdf6ab12f3b4f0 100644 (file)
@@ -104,6 +104,7 @@ unique=False, """
                 """postgresql_where=sa.text('t.y = %(y_1)s'))"""
             )
 
+    @config.requirements.fail_before_sqla_080
     def test_render_add_index_func(self):
         m = MetaData()
         t = Table(
@@ -118,6 +119,7 @@ unique=False, """
             "[sa.text('lower(test.code)')], unique=False)"
         )
 
+    @config.requirements.fail_before_sqla_080
     def test_render_add_index_cast(self):
         m = MetaData()
         t = Table(
@@ -132,6 +134,7 @@ unique=False, """
             "[sa.text('CAST(test.code AS CHAR)')], unique=False)"
         )
 
+    @config.requirements.fail_before_sqla_080
     def test_render_add_index_desc(self):
         m = MetaData()
         t = Table(
@@ -853,6 +856,7 @@ render:primary_key\n)"""
             'nullable=False)'
         )
 
+    @config.requirements.fail_before_sqla_09
     def test_render_server_default_non_native_boolean(self):
         c = Column(
             'updated_at', Boolean(),