lib:ldb: Use tdb_parse_record() in ldb_kv_sub_transaction_traverse()

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>

diff --git a/lib/ldb/ldb_key_value/ldb_kv_index.c b/lib/ldb/ldb_key_value/ldb_kv_index.c
index 6a265166e1d4b922bc2291ae809b5768c7cba2e5..cbc594e545716bf619d3691e2ec867f2aaa70b4b 100644 (file)
--- a/lib/ldb/ldb_key_value/ldb_kv_index.c
+++ b/lib/ldb/ldb_key_value/ldb_kv_index.c
@@ -3888,6 +3888,9 @@ static int ldb_kv_sub_transaction_traverse(
        TDB_DATA rec = {0};
        struct dn_list *index_in_subtransaction = NULL;
        struct dn_list *index_in_top_level = NULL;
+       struct ldb_dn_list_state sub_state = {
+               .module = module,
+       };
        int ret = 0;
 
        /*
@@ -3908,10 +3911,12 @@ static int ldb_kv_sub_transaction_traverse(
         * The TDB and so the fetched rec contains NO DATA, just a
         * pointer to data held in memory.
         */
-       rec = tdb_fetch(ldb_kv->idxptr->itdb, key);
-       if (rec.dptr != NULL) {
-               index_in_top_level = ldb_kv_index_idxptr(module, rec);
-               free(rec.dptr);
+       ret = tdb_parse_record(ldb_kv->idxptr->itdb,
+                              key,
+                              ldb_kv_index_idxptr_wrapper,
+                              &sub_state);
+       if (ret == 0) {
+               index_in_top_level = sub_state.list;
                if (index_in_top_level == NULL) {
                        abort();
                }