]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
gpio: wcove: use regmap_assign_bits() in .set()
authorBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Tue, 15 Jul 2025 08:19:44 +0000 (10:19 +0200)
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Wed, 16 Jul 2025 08:26:08 +0000 (10:26 +0200)
Replace the if-else with a direct call to the regmap_assign_bits()
helper and save a couple lines of code.

Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20250715-gpiochip-set-rv-gpio-remaining-v2-1-072b4cf06330@linaro.org
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
drivers/gpio/gpio-wcove.c

index 1ec24f6f9300f33f5b3f0f8deb539e08392b8188..816fb8d113e66b27070f286755f3192b2a8f8512 100644 (file)
@@ -208,10 +208,7 @@ static void wcove_gpio_set(struct gpio_chip *chip, unsigned int gpio, int value)
        if (reg < 0)
                return;
 
-       if (value)
-               regmap_set_bits(wg->regmap, reg, 1);
-       else
-               regmap_clear_bits(wg->regmap, reg, 1);
+       regmap_assign_bits(wg->regmap, reg, 1, value);
 }
 
 static int wcove_gpio_set_config(struct gpio_chip *chip, unsigned int gpio,