staging: media: av7110: replace BUG() with error return in gpioirq

Replace BUG() with a return statement in the gpioirq tasklet handler.
If saa7146_wait_for_debi_done() times out, crashing the kernel is
disproportionate. The pr_err() already logs the failure, and returning
early avoids accessing hardware in a potentially broken state.

Signed-off-by: Artem Lytkin <iprintercanon@gmail.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>

diff --git a/drivers/staging/media/av7110/av7110.c b/drivers/staging/media/av7110/av7110.c
index 607992100baf2f40d436604aacee360f327a0623..014d0c6f0a8ba06435b0a428190e563d72fe6725 100644 (file)
--- a/drivers/staging/media/av7110/av7110.c
+++ b/drivers/staging/media/av7110/av7110.c
@@ -460,7 +460,7 @@ static void gpioirq(struct tasklet_struct *t)
 
        if (saa7146_wait_for_debi_done(av7110->dev, 0)) {
                pr_err("%s(): saa7146_wait_for_debi_done timed out\n", __func__);
-               BUG(); /* maybe we should try resetting the debi? */
+               return;
        }
 
        spin_lock(&av7110->debilock);