Added period check in PeriodicCallback

If a user currently passes in 0ms (hopefully by accident) as the
callback time for a periodic callback, Tornado consumes a huge amount
of CPU and never calls the function.

diff --git a/tornado/ioloop.py b/tornado/ioloop.py
index 02046d3d164435def76281391a9322943fb572cf..dfbb462b3417e0e2d431c5fe4803b3e170db9f0a 100644 (file)
--- a/tornado/ioloop.py
+++ b/tornado/ioloop.py
@@ -679,6 +679,8 @@ class PeriodicCallback(object):
     """
     def __init__(self, callback, callback_time, io_loop=None):
         self.callback = callback
+        if callback_time == 0:
+            raise ValueError("Periodic callback cannot have a period of 0ms")
         self.callback_time = callback_time
         self.io_loop = io_loop or IOLoop.instance()
         self._running = False