tests/krb5: Add account to cleanup list before adding it to database

This ensures accounts are still cleaned up if a test fails before adding
it to the cleanup list.

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

diff --git a/python/samba/tests/krb5/kdc_base_test.py b/python/samba/tests/krb5/kdc_base_test.py
index 2d3123109c8eae42f79fc0a6dd38e2d23df6bf63..7a58f2bbbef5dda616cf48cab11ae2b35fc14211 100644 (file)
--- a/python/samba/tests/krb5/kdc_base_test.py
+++ b/python/samba/tests/krb5/kdc_base_test.py
@@ -299,6 +299,8 @@ class KDCBaseTest(RawKerberosTest):
             details["userPrincipalName"] = upn
         if additional_details is not None:
             details.update(additional_details)
+        # Save the account name so it can be deleted in tearDownClass
+        self.accounts.append(dn)
         samdb.add(details)
 
         creds = KerberosCredentials()
@@ -314,9 +316,6 @@ class KDCBaseTest(RawKerberosTest):
         creds.set_dn(ldb.Dn(samdb, dn))
         creds.set_upn(upn)
         creds.set_spn(spn)
-        #
-        # Save the account name so it can be deleted in tearDownClass
-        self.accounts.append(dn)
 
         self.creds_set_enctypes(creds)