vala: Using SignalHandler.disconnect() is required for dynamic signals

diff --git a/tests/Makefile.am b/tests/Makefile.am
index 2628320bb3aea8f117c4930293a1906b1ec04738..413132a6f87f407724f0e7c77273f3c6fed9f008 100644 (file)
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -539,6 +539,7 @@ TESTS = \
        objects/signals-enum-marshal.vala \
        objects/signals-delegate.vala \
        objects/signals-delegate-parameter.vala \
+       objects/signals-dynamic-invalid-disconnect.test \
        objects/signals-dymanic-invalid-handler.test \
        objects/signals-dynamic-lambda-handler.test \
        objects/signals-error-marshal.vala \

diff --git a/tests/objects/signals-dynamic-invalid-disconnect.test b/tests/objects/signals-dynamic-invalid-disconnect.test
new file mode 100644 (file)
index 0000000..e1787ef
--- /dev/null
+++ b/tests/objects/signals-dynamic-invalid-disconnect.test
@@ -0,0 +1,15 @@
+Invalid Code
+
+class Foo : Object {
+       public signal void sig ();
+}
+
+void sig_cb () {
+}
+
+void main () {
+       var real = new Foo ();
+       dynamic Object foo = real;
+
+       foo.sig.disconnect (sig_cb);
+}

diff --git a/vala/valamemberaccess.vala b/vala/valamemberaccess.vala
index f3b87994ac31109aeba4971d6ab40bd9ae48b927..c8b3b267bbbaddad19de914e4daa67e1af7a76f0 100644 (file)
--- a/vala/valamemberaccess.vala
+++ b/vala/valamemberaccess.vala
@@ -499,6 +499,9 @@ public class Vala.MemberAccess : Expression {
                                                s.access = SymbolAccessibility.PUBLIC;
                                                dynamic_object_type.type_symbol.scope.add (null, s);
                                                symbol_reference = s;
+                                       } else if (ma.member_name == "disconnect") {
+                                               error = true;
+                                               Report.error (ma.source_reference, "Use SignalHandler.disconnect() to disconnect from dynamic signal");
                                        }
                                }
                                if (symbol_reference == null) {