]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: Move qemuDomainSupportsPCI() to qemu_domain
authorAndrea Bolognani <abologna@redhat.com>
Wed, 28 Nov 2018 16:45:37 +0000 (17:45 +0100)
committerAndrea Bolognani <abologna@redhat.com>
Fri, 8 Feb 2019 15:16:22 +0000 (16:16 +0100)
The function operates on a virDomainDef and is not tied to
device address assignment in any way, so it makes more sense
for it to live along with qemuDomainIs*() and the like.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
src/qemu/qemu_domain.c
src/qemu/qemu_domain.h
src/qemu/qemu_domain_address.c

index 09a55703127964c279633f5a5eb5463fe3c9c269..b8d64290bc9f4a94d69e3bcdf81253311f2e7836 100644 (file)
@@ -10085,6 +10085,28 @@ qemuDomainNeedsFDC(const virDomainDef *def)
 }
 
 
+bool
+qemuDomainSupportsPCI(virDomainDefPtr def,
+                      virQEMUCapsPtr qemuCaps)
+{
+    if ((def->os.arch != VIR_ARCH_ARMV6L) &&
+        (def->os.arch != VIR_ARCH_ARMV7L) &&
+        (def->os.arch != VIR_ARCH_AARCH64) &&
+        !ARCH_IS_RISCV(def->os.arch))
+        return true;
+
+    if (STREQ(def->os.machine, "versatilepb"))
+        return true;
+
+    if ((qemuDomainIsARMVirt(def) ||
+         qemuDomainIsRISCVVirt(def)) &&
+        virQEMUCapsGet(qemuCaps, QEMU_CAPS_OBJECT_GPEX))
+        return true;
+
+    return false;
+}
+
+
 static bool
 qemuCheckMemoryDimmConflict(const virDomainDef *def,
                             const virDomainMemoryDef *mem)
index b934fe3088d0022d522cfa4b2e1a88ad6d1656e9..7c6b50184c8d12eb8bed4492f0c5cb3063011aa5 100644 (file)
@@ -847,6 +847,8 @@ bool qemuDomainHasPCIRoot(const virDomainDef *def);
 bool qemuDomainHasPCIeRoot(const virDomainDef *def);
 bool qemuDomainHasBuiltinIDE(const virDomainDef *def);
 bool qemuDomainNeedsFDC(const virDomainDef *def);
+bool qemuDomainSupportsPCI(virDomainDefPtr def,
+                           virQEMUCapsPtr qemuCaps);
 
 void qemuDomainUpdateCurrentMemorySize(virDomainObjPtr vm);
 
index c35ecd8585db7863477bdf4e477307afd0dbba58..32fdd59566d99eaa02be6b80812628a62f1abd4b 100644 (file)
@@ -2356,28 +2356,6 @@ qemuDomainAssignDevicePCISlots(virDomainDefPtr def,
 }
 
 
-static bool
-qemuDomainSupportsPCI(virDomainDefPtr def,
-                      virQEMUCapsPtr qemuCaps)
-{
-    if ((def->os.arch != VIR_ARCH_ARMV6L) &&
-        (def->os.arch != VIR_ARCH_ARMV7L) &&
-        (def->os.arch != VIR_ARCH_AARCH64) &&
-        !ARCH_IS_RISCV(def->os.arch))
-        return true;
-
-    if (STREQ(def->os.machine, "versatilepb"))
-        return true;
-
-    if ((qemuDomainIsARMVirt(def) ||
-         qemuDomainIsRISCVVirt(def)) &&
-        virQEMUCapsGet(qemuCaps, QEMU_CAPS_OBJECT_GPEX))
-        return true;
-
-    return false;
-}
-
-
 static void
 qemuDomainPCIControllerSetDefaultModelName(virDomainControllerDefPtr cont,
                                            virDomainDefPtr def,