]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
PCI: qcom: Prevent use of uninitialized data in qcom_pcie_suspend_noirq()
authorDan Carpenter <dan.carpenter@linaro.org>
Mon, 8 Jul 2024 18:05:38 +0000 (13:05 -0500)
committerKrzysztof Wilczyński <kwilczynski@kernel.org>
Wed, 10 Jul 2024 05:39:15 +0000 (05:39 +0000)
Smatch complains that "ret" could be uninitialized if "pcie->icc_mem" is
NULL and "pm_suspend_target_state == PM_SUSPEND_MEM".

Silence this warning by initializing ret to zero.

Fixes: 78b5f6f8855e ("PCI: qcom: Add OPP support to scale performance")
Link: https://lore.kernel.org/linux-pci/20240708180539.1447307-4-dan.carpenter@linaro.org
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Tested-by: Anders Roxell <anders.roxell@linaro.org>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
drivers/pci/controller/dwc/pcie-qcom.c

index 5973df2238b062aceea670dd8b8fbedfc8dcf9c3..e60432b238fb51dbfb6426406e8f062e1855bfaf 100644 (file)
@@ -1637,7 +1637,7 @@ err_pm_runtime_put:
 static int qcom_pcie_suspend_noirq(struct device *dev)
 {
        struct qcom_pcie *pcie = dev_get_drvdata(dev);
-       int ret;
+       int ret = 0;
 
        /*
         * Set minimum bandwidth required to keep data path functional during