]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
gpib: agilent_82357a: Fix the *allocate_private retval check
authorDominik Karol Piątkowski <dominik.karol.piatkowski@protonmail.com>
Fri, 16 Jan 2026 17:47:35 +0000 (17:47 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 27 Jan 2026 15:04:06 +0000 (16:04 +0100)
Change

if (retval < 0)
return retval;

into

if (retval)
return retval;

as it is more fitting in this case.

Signed-off-by: Dominik Karol Piątkowski <dominik.karol.piatkowski@protonmail.com>
Link: https://patch.msgid.link/20260116174647.317256-3-dominik.karol.piatkowski@protonmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/gpib/agilent_82357a/agilent_82357a.c

index 77c8e549b2080047eda0db6fadf2c08ba828c1fd..26d2830c3fa38776c1de24ee14e97d487ae0c44a 100644 (file)
@@ -1316,7 +1316,7 @@ static int agilent_82357a_attach(struct gpib_board *board, const struct gpib_boa
                return -ERESTARTSYS;
 
        retval = agilent_82357a_allocate_private(board);
-       if (retval < 0) {
+       if (retval) {
                mutex_unlock(&agilent_82357a_hotplug_lock);
                return retval;
        }