Bug 302200: uninitialized value when saving email prefs - Patch by Rob Siklos <robzil...

diff --git a/userprefs.cgi b/userprefs.cgi
index be6f40b049d4db3557fd4589bb2477eff5571acd..57cbda28cf4714a6b16c5f99933f9ed07a4cadb9 100755 (executable)
--- a/userprefs.cgi
+++ b/userprefs.cgi
@@ -253,7 +253,9 @@ sub SaveEmail {
 
     # Global positive events: a ticked box means "send me mail."
     foreach my $event (GLOBAL_EVENTS) {
-        if (1 == $cgi->param("email-" . REL_ANY . "-$event")) {
+        if (defined($cgi->param("email-" . REL_ANY . "-$event"))
+            && $cgi->param("email-" . REL_ANY . "-$event") == 1)
+        {
             $dbh->do("INSERT INTO email_setting " . 
                      "(user_id, relationship, event) " . 
                      "VALUES ($userid, " . REL_ANY . ", $event)");