tty: nozomi: Fix a resource leak in an error handling function

[ Upstream commit 31a9a318255960d32ae183e95d0999daf2418608 ]

A 'request_irq()' call is not balanced by a corresponding 'free_irq()' in
the error handling path, as already done in the remove function.

Add it.

Fixes: 9842c38e9176 ("kfifo: fix warn_unused_result")
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/4f0d2b3038e82f081d370ccb0cade3ad88463fe7.1620580838.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/tty/nozomi.c b/drivers/tty/nozomi.c
index 5cc80b80c82b6cb0a90d6887d188510d60e228f5..880cfc780e679eaf033aeab6537d9a79e700a0d1 100644 (file)
--- a/drivers/tty/nozomi.c
+++ b/drivers/tty/nozomi.c
@@ -1479,6 +1479,7 @@ err_free_tty:
                tty_unregister_device(ntty_driver, dc->index_start + i);
                tty_port_destroy(&dc->port[i].port);
        }
+       free_irq(pdev->irq, dc);
 err_free_kfifo:
        for (i = 0; i < MAX_PORT; i++)
                kfifo_free(&dc->port[i].fifo_ul);