]> git.ipfire.org Git - thirdparty/xfsprogs-dev.git/commitdiff
xfs_db: fix too-large memset value in attr code
authorEric Sandeen <sandeen@redhat.com>
Mon, 14 Apr 2014 06:13:39 +0000 (16:13 +1000)
committerDave Chinner <david@fromorbit.com>
Mon, 14 Apr 2014 06:13:39 +0000 (16:13 +1000)
memset(value, 0xfeedface, valuelen);

seemed to be trying to fill a new attr with some
recognizeable magic, but of course memset can
only set a single byte; switch this to use 'v'

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
db/attrset.c

index 75be72ec191ad48805c9360ab670e0c436714435..762b3bf3cef6ae004be4f2dd376e488aea691260 100644 (file)
@@ -146,7 +146,7 @@ attr_set_f(
                        dbprintf(_("cannot allocate buffer (%d)\n"), valuelen);
                        goto out;
                }
-               memset(value, 0xfeedface, valuelen);
+               memset(value, 'v', valuelen);
        } else {
                value = NULL;
        }