]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
media: ipu6: Don't check pipeline in stream_start
authorSakari Ailus <sakari.ailus@linux.intel.com>
Fri, 7 Nov 2025 10:46:51 +0000 (12:46 +0200)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Tue, 13 Jan 2026 11:47:56 +0000 (12:47 +0100)
A pipeline exists when start_streaming has returned so the check for
start_streaming_called is equivalent to having media_pipeline. Use
vb2_start_streaming_called() to perform the check.

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: Bingbu Cao <bingbu.cao@intel.com>
Tested-by: Mehdi Djait <mehdi.djait@linux.intel.com> # Dell XPS 9315
Reviewed-by: Mehdi Djait <mehdi.djait@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/pci/intel/ipu6/ipu6-isys-queue.c

index fdf41b3cf60ea5047403f3124f89b964f11c7721..dcad6aafee294341f5bc79953e1c849fbb6513d7 100644 (file)
@@ -355,8 +355,6 @@ static void buf_queue(struct vb2_buffer *vb)
                vb2_buffer_to_ipu6_isys_video_buffer(vvb);
        struct ipu6_isys_buffer *ib = &ivb->ib;
        struct device *dev = &av->isys->adev->auxdev.dev;
-       struct media_pipeline *media_pipe =
-               media_entity_pipeline(&av->vdev.entity);
        struct ipu6_fw_isys_frame_buff_set_abi *buf = NULL;
        struct ipu6_isys_stream *stream = av->stream;
        struct ipu6_isys_buffer_list bl;
@@ -374,8 +372,8 @@ static void buf_queue(struct vb2_buffer *vb)
        list_add(&ib->head, &aq->incoming);
        spin_unlock_irqrestore(&aq->lock, flags);
 
-       if (!media_pipe || !vb->vb2_queue->start_streaming_called) {
-               dev_dbg(dev, "media pipeline is not ready for %s\n",
+       if (!vb2_start_streaming_called(vb->vb2_queue)) {
+               dev_dbg(dev, "start_streaming hasn't been called yet on %s\n",
                        av->vdev.name);
                return;
        }