]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
xprtrdma: Fix I3 invariant comment in rpcrdma_complete_rqst
authorChuck Lever <chuck.lever@oracle.com>
Mon, 1 Jun 2026 17:54:12 +0000 (13:54 -0400)
committerAnna Schumaker <anna.schumaker@hammerspace.com>
Mon, 8 Jun 2026 14:21:56 +0000 (10:21 -0400)
frwr_unmap_sync() and frwr_unmap_async() drain rl_registered via
rpcrdma_mr_pop() before posting invalidation Work Requests to
hardware.  The WARN_ON_ONCE verifies that the list-drain step
has occurred, not that hardware unmapping has completed.

Reword the comment to match what the assertion actually checks.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Anna Schumaker <anna.schumaker@hammerspace.com>
net/sunrpc/xprtrdma/rpc_rdma.c

index 626cadec4555de084e50d770f6dacf276e2ac7c9..f115baba6d56300b8d00b1e6dceac70cadd5d0b0 100644 (file)
@@ -1336,8 +1336,8 @@ void rpcrdma_complete_rqst(struct rpcrdma_rep *rep)
        struct rpc_rqst *rqst = rep->rr_rqst;
        int status;
 
-       /* I3: every registered MR has been invalidated and
-        * ib_dma_unmap_sg()'d before complete_rqst runs.
+       /* I3: rl_registered has been drained by frwr_unmap before
+        * complete_rqst runs.
         */
        WARN_ON_ONCE(!list_empty(&rpcr_to_rdmar(rqst)->rl_registered));