]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
drm/bridge: anx7625: Use common macros for DP power sequencing commands
authorChen-Yu Tsai <wenst@chromium.org>
Mon, 10 Jul 2023 09:09:27 +0000 (17:09 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 13 Sep 2023 07:48:13 +0000 (09:48 +0200)
[ Upstream commit 2ba776f903cb7157e80b5f314fb0b4faf6ea6958 ]

The DRM DP code has macros for the DP power sequencing commands. Use
them in the anx7625 driver instead of raw numbers.

Fixes: 548b512e144f ("drm/bridge: anx7625: send DPCD command to downstream")
Fixes: 27f26359de9b ("drm/bridge: anx7625: Set downstream sink into normal status")
Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
Reviewed-by: NĂ­colas F. R. A. Prado <nfraprado@collabora.com>
Signed-off-by: Robert Foss <rfoss@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20230710090929.1873646-1-wenst@chromium.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/bridge/analogix/anx7625.c

index 9e387c3e9b696b8dda0fd4ba027baa718df70594..4f1286d948bdea3da600be1c8be32478b6340b33 100644 (file)
@@ -932,8 +932,8 @@ static void anx7625_dp_start(struct anx7625_data *ctx)
 
        dev_dbg(dev, "set downstream sink into normal\n");
        /* Downstream sink enter into normal mode */
-       data = 1;
-       ret = anx7625_aux_trans(ctx, DP_AUX_NATIVE_WRITE, 0x000600, 1, &data);
+       data = DP_SET_POWER_D0;
+       ret = anx7625_aux_trans(ctx, DP_AUX_NATIVE_WRITE, DP_SET_POWER, 1, &data);
        if (ret < 0)
                dev_err(dev, "IO error : set sink into normal mode fail\n");
 
@@ -972,8 +972,8 @@ static void anx7625_dp_stop(struct anx7625_data *ctx)
 
        dev_dbg(dev, "notify downstream enter into standby\n");
        /* Downstream monitor enter into standby mode */
-       data = 2;
-       ret |= anx7625_aux_trans(ctx, DP_AUX_NATIVE_WRITE, 0x000600, 1, &data);
+       data = DP_SET_POWER_D3;
+       ret |= anx7625_aux_trans(ctx, DP_AUX_NATIVE_WRITE, DP_SET_POWER, 1, &data);
        if (ret < 0)
                DRM_DEV_ERROR(dev, "IO error : mute video fail\n");