]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
phy: realtek: usb: fix NULL deref in rtk_usb2phy_probe
authorCharles Han <hanchunchao@inspur.com>
Fri, 25 Oct 2024 06:59:12 +0000 (14:59 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 4 Nov 2024 01:03:17 +0000 (02:03 +0100)
In rtk_usb2phy_probe() devm_kzalloc() may return NULL
but this returned value is not checked.

Fixes: 134e6d25f6bd ("phy: realtek: usb: Add driver for the Realtek SoC USB 2.0 PHY")
Signed-off-by: Charles Han <hanchunchao@inspur.com>
Link: https://lore.kernel.org/r/20241025065912.143692-1-hanchunchao@inspur.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/phy/realtek/phy-rtk-usb2.c

index e3ad7cea510998158bde80f40b421e21e9023dca..e8ca2ec5998fe6ad73a9f009019c1ad8b3890b4d 100644 (file)
@@ -1023,6 +1023,8 @@ static int rtk_usb2phy_probe(struct platform_device *pdev)
 
        rtk_phy->dev                    = &pdev->dev;
        rtk_phy->phy_cfg = devm_kzalloc(dev, sizeof(*phy_cfg), GFP_KERNEL);
+       if (!rtk_phy->phy_cfg)
+               return -ENOMEM;
 
        memcpy(rtk_phy->phy_cfg, phy_cfg, sizeof(*phy_cfg));