]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
virDomainChrDefParseXML: don't leak upon invalid input
authorJim Meyering <meyering@redhat.com>
Thu, 4 Feb 2010 11:49:53 +0000 (12:49 +0100)
committerJim Meyering <meyering@redhat.com>
Thu, 4 Feb 2010 19:00:07 +0000 (20:00 +0100)
* src/conf/domain_conf.c (virDomainChrDefParseXML): Don't leak a
virDomainChrDef buffer upon "unknown target type for char device" error.

src/conf/domain_conf.c

index 766993c58678ecc169b04723ac4e9f5fac23f1cb..306776de1d65c4c3c5dce1475816147fc14a622d 100644 (file)
@@ -1947,6 +1947,7 @@ virDomainChrDefParseXML(virConnectPtr conn,
             virDomainReportError(conn, VIR_ERR_XML_ERROR,
                               _("unknown target type for character device: %s"),
                                  nodeName);
+            VIR_FREE(def);
             return NULL;
         }
         def->targetType = VIR_DOMAIN_CHR_TARGET_TYPE_NULL;