]> git.ipfire.org Git - thirdparty/qemu.git/commitdiff
block: mark bdrv_insert_node() as GRAPH_UNLOCKED
authorFiona Ebner <f.ebner@proxmox.com>
Fri, 30 May 2025 15:11:20 +0000 (17:11 +0200)
committerKevin Wolf <kwolf@redhat.com>
Mon, 14 Jul 2025 13:42:22 +0000 (15:42 +0200)
The function bdrv_insert_node() calls bdrv_drained_begin() which must
be called with the graph unlocked.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
Message-ID: <20250530151125.955508-44-f.ebner@proxmox.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
include/block/block-global-state.h

index 706a2cde36c74023da609945b018b07ee5edc596..cb4d8bca220145980ca29e381447eeb6cff796c6 100644 (file)
@@ -76,8 +76,9 @@ bdrv_replace_node(BlockDriverState *from, BlockDriverState *to, Error **errp);
 
 int GRAPH_UNLOCKED
 bdrv_replace_child_bs(BdrvChild *child, BlockDriverState *new_bs, Error **errp);
-BlockDriverState *bdrv_insert_node(BlockDriverState *bs, QDict *node_options,
-                                   int flags, Error **errp);
+BlockDriverState * GRAPH_UNLOCKED
+bdrv_insert_node(BlockDriverState *bs, QDict *node_options, int flags,
+                 Error **errp);
 int bdrv_drop_filter(BlockDriverState *bs, Error **errp);
 
 BdrvChild * no_coroutine_fn