delete all matchine local variables

they can be created in any order, so we can't rely on just checking
the tail

diff --git a/src/lib/unlang/interpret.c b/src/lib/unlang/interpret.c
index 1fa2101c8ec7a5a8137582e7f612de239b6987ea..4ceae8df2ae9d06afb30ebec23fde55e41b28706 100644 (file)
--- a/src/lib/unlang/interpret.c
+++ b/src/lib/unlang/interpret.c
@@ -217,9 +217,7 @@ typedef struct {
 
 static int _local_variables_free(unlang_variable_ref_t *ref)
 {
-       fr_pair_t *vp;
-
-       while ((vp = fr_pair_list_tail(&ref->request->local_pairs)) != NULL) {
+       fr_pair_list_foreach(&ref->request->local_pairs, vp) {
                if (vp->da->dict != ref->dict) break;
 
                (void) fr_pair_delete(&ref->request->local_pairs, vp);