]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
ctdb-scripts: Use ss -H option to simplify
authorMartin Schwenke <mschwenke@ddn.com>
Mon, 16 Sep 2024 02:26:53 +0000 (12:26 +1000)
committerMartin Schwenke <martins@samba.org>
Wed, 6 Nov 2024 23:03:42 +0000 (23:03 +0000)
This option has been available since ~2018 and has been implemented in
the stub since then.  I guess we didn't use it because CentOS 7?

Signed-off-by: Martin Schwenke <mschwenke@ddn.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jerry Heyman <jheyman@ddn.com>
ctdb/config/functions

index 85757a89744a52e0f658dbcf3090fb8e105953b5..6fad34797708f3105b1260f377d8ecf4686530b7 100755 (executable)
@@ -499,7 +499,7 @@ ctdb_check_unix_socket()
                return 1
        fi
 
-       _out=$(ss -l -x "src ${_sockpath}" | tail -n +2)
+       _out=$(ss -l -xH "src ${_sockpath}")
        if [ -z "$_out" ]; then
                echo "ERROR: ${service_name} not listening on ${_sockpath}"
                return 1
@@ -602,7 +602,7 @@ get_tcp_connections_for_ip()
 {
        _ip="$1"
 
-       ss -tn state established "src [$_ip]" | awk 'NR > 1 {print $3, $4}'
+       ss -tnH state established "src [$_ip]" | awk '{print $3, $4}'
 }
 
 ########################################################
@@ -1205,10 +1205,10 @@ update_tickles()
        _my_connections="${tickledir}/${_port}.connections.$$"
        # Parentheses are needed around the filters for precedence but
        # the parentheses can't be empty!
-       ss -tn state established \
+       ss -tnH state established \
                "${_ip_filter:+( ${_ip_filter} )}" \
                "${_port_filter:+( ${_port_filter} )}" |
-               awk 'NR > 1 {print $4, $3}' |
+               awk '{print $4, $3}' |
                sort >"$_my_connections"
 
        # Record our current tickles in a temporary file