]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
platform/x86/intel/uncore-freq: Replace sprintf() with scnprintf()
authorKaushlendra Kumar <kaushlendra.kumar@intel.com>
Tue, 30 Dec 2025 12:45:15 +0000 (18:15 +0530)
committerIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Tue, 6 Jan 2026 08:57:08 +0000 (10:57 +0200)
Replace unbounded sprintf() calls with scnprintf() to prevent potential
buffer overflows when formatting device names. While the current format
strings cannot overflow the buffer, using scnprintf() follows kernel
best practices for string formatting.

Signed-off-by: Kaushlendra Kumar <kaushlendra.kumar@intel.com>
Link: https://patch.msgid.link/20251230124516.229125-2-kaushlendra.kumar@intel.com
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
drivers/platform/x86/intel/uncore-frequency/uncore-frequency-common.c

index 65897fae17dfbac81ab9ae9ec7a18365704470ad..e9495ac5ecd058d1270144521d5a02573720a201 100644 (file)
@@ -269,9 +269,10 @@ int uncore_freq_add_entry(struct uncore_data *data, int cpu)
                        goto uncore_unlock;
 
                data->instance_id = ret;
-               sprintf(data->name, "uncore%02d", ret);
+               scnprintf(data->name, sizeof(data->name), "uncore%02d", ret);
        } else {
-               sprintf(data->name, "package_%02d_die_%02d", data->package_id, data->die_id);
+               scnprintf(data->name, sizeof(data->name), "package_%02d_die_%02d",
+                         data->package_id, data->die_id);
        }
 
        uncore_read(data, &data->initial_min_freq_khz, UNCORE_INDEX_MIN_FREQ);