]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
UBI: initialize LEB number variable
authorBrian Norris <computersforpeace@gmail.com>
Sat, 28 Feb 2015 10:23:27 +0000 (02:23 -0800)
committerZefan Li <lizefan@huawei.com>
Fri, 18 Sep 2015 01:20:25 +0000 (09:20 +0800)
commit f16db8071ce18819fbd705ddcc91c6f392fb61f8 upstream.

In some of the 'out_not_moved' error paths, lnum may be used
uninitialized. Don't ignore the warning; let's fix it.

This uninitialized variable doesn't have much visible effect in the end,
since we just schedule the PEB for erasure, and its LEB number doesn't
really matter (it just gets printed in debug messages). But let's get it
straight anyway.

Coverity CID #113449

Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
[lizf: Backported to 3.4: adjust context]
Signed-off-by: Zefan Li <lizefan@huawei.com>
drivers/mtd/ubi/wl.c

index 7c1a9bf8ac869592e2697b1217bc9261197dc11b..284d144ff5a651dbbb236cb89b25259653999efe 100644 (file)
@@ -666,7 +666,7 @@ static int wear_leveling_worker(struct ubi_device *ubi, struct ubi_work *wrk,
                                int cancel)
 {
        int err, scrubbing = 0, torture = 0, protect = 0, erroneous = 0;
-       int vol_id = -1, uninitialized_var(lnum);
+       int vol_id = -1, lnum = -1;
        struct ubi_wl_entry *e1, *e2;
        struct ubi_vid_hdr *vid_hdr;