]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
cache: ax45mp: Fix device node reference leak in ax45mp_cache_init()
authorFelix Gu <ustc.gu@gmail.com>
Fri, 30 Jan 2026 17:49:09 +0000 (01:49 +0800)
committerConor Dooley <conor.dooley@microchip.com>
Fri, 6 Feb 2026 19:54:40 +0000 (19:54 +0000)
In ax45mp_cache_init(), of_find_matching_node() returns a device node
with an incremented reference count that must be released with
of_node_put(). The current code fails to call of_node_put() which
causes a reference leak.

Use the __free(device_node) attribute to ensure automatic cleanup when
the variable goes out of scope.

Fixes: d34599bcd2e4 ("cache: Add L2 cache management for Andes AX45MP RISC-V core")
Signed-off-by: Felix Gu <ustc.gu@gmail.com>
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
drivers/cache/ax45mp_cache.c

index 1d7dd3d2c101cd4412876d62162fb733c800c02c..934c5087ec2bdaa18f878e028d10720ba37e770d 100644 (file)
@@ -178,11 +178,11 @@ static const struct of_device_id ax45mp_cache_ids[] = {
 
 static int __init ax45mp_cache_init(void)
 {
-       struct device_node *np;
        struct resource res;
        int ret;
 
-       np = of_find_matching_node(NULL, ax45mp_cache_ids);
+       struct device_node *np __free(device_node) =
+               of_find_matching_node(NULL, ax45mp_cache_ids);
        if (!of_device_is_available(np))
                return -ENODEV;