]> git.ipfire.org Git - thirdparty/apache/httpd.git/commitdiff
Fix a signed/unsigned comparison that can never match.
authorChristophe Jaillet <jailletc36@apache.org>
Sat, 10 Aug 2019 08:59:13 +0000 (08:59 +0000)
committerChristophe Jaillet <jailletc36@apache.org>
Sat, 10 Aug 2019 08:59:13 +0000 (08:59 +0000)
(+ add a missing space to improve formating)

Spotted by gcc 9.1 and -Wextra

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1864865 13f79535-47bb-0310-9956-ffa450edef68

server/protocol.c

index 4c79ae165a66daa8d4418ad00fa6b12b2a043801..7a97b0d98e91b487e1abeb6d1bb4dde50b83ef27 100644 (file)
@@ -2145,7 +2145,7 @@ static int r_flush(apr_vformatter_buff_t *buff)
 
 AP_DECLARE(int) ap_vrprintf(request_rec *r, const char *fmt, va_list va)
 {
-    apr_size_t written;
+    int written;
     struct ap_vrprintf_data vd;
     char vrprintf_buf[AP_IOBUFSIZE];
 
@@ -2163,7 +2163,7 @@ AP_DECLARE(int) ap_vrprintf(request_rec *r, const char *fmt, va_list va)
         int n = vd.vbuff.curpos - vrprintf_buf;
 
         /* last call to buffer_output, to finish clearing the buffer */
-        if (buffer_output(r, vrprintf_buf,n) != APR_SUCCESS)
+        if (buffer_output(r, vrprintf_buf, n) != APR_SUCCESS)
             return -1;
 
         written += n;