virfirewalltest: Don't duplicate string when adding it onto stringlist

In our wrapper of g_dbus_connection_call_sync() in
virfirewalltest a string is duplicated and added onto a
virStringList. This leads to a memory leak because
virStringListAdd() duplicates the string itself.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Pavel Hrdina <phrdina@redhat.com>

diff --git a/tests/virfirewalltest.c b/tests/virfirewalltest.c
index 646b999d96e0c040fe9ed133fa96e013af56b0fb..dc631dfc5dce7313a9a05d4401938985c30fea2b 100644 (file)
--- a/tests/virfirewalltest.c
+++ b/tests/virfirewalltest.c
@@ -122,7 +122,7 @@ VIR_MOCK_WRAP_RET_ARGS(g_dbus_connection_call_sync,
                 doError = true;
             }
 
-            virStringListAdd(&args, g_strdup(item));
+            virStringListAdd(&args, item);
         }
 
         if (fwBuf) {