]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
phy: amlogic: phy-meson-gxl-usb2: Simplify error handling with dev_err_probe()
authorAnand Moon <linux.amoon@gmail.com>
Thu, 10 Apr 2025 13:33:16 +0000 (19:03 +0530)
committerVinod Koul <vkoul@kernel.org>
Fri, 11 Apr 2025 11:37:15 +0000 (17:07 +0530)
Use dev_err_probe() for phy resources to indicate the deferral
reason when waiting for the resource to come up.

Signed-off-by: Anand Moon <linux.amoon@gmail.com>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://lore.kernel.org/r/20250410133332.294556-2-linux.amoon@gmail.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/amlogic/phy-meson-gxl-usb2.c

index 14ea89927ab142dbf27670e305b480993e128588..6b390304f723ca36fd1a74b00d4cbfa382a5b330 100644 (file)
@@ -237,7 +237,6 @@ static int phy_meson_gxl_usb2_probe(struct platform_device *pdev)
        struct phy_meson_gxl_usb2_priv *priv;
        struct phy *phy;
        void __iomem *base;
-       int ret;
 
        priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
        if (!priv)
@@ -266,13 +265,9 @@ static int phy_meson_gxl_usb2_probe(struct platform_device *pdev)
                return PTR_ERR(priv->reset);
 
        phy = devm_phy_create(dev, NULL, &phy_meson_gxl_usb2_ops);
-       if (IS_ERR(phy)) {
-               ret = PTR_ERR(phy);
-               if (ret != -EPROBE_DEFER)
-                       dev_err(dev, "failed to create PHY\n");
-
-               return ret;
-       }
+       if (IS_ERR(phy))
+               return dev_err_probe(dev, PTR_ERR(phy),
+                                    "failed to create PHY\n");
 
        phy_set_drvdata(phy, priv);