# Rights Reserved.
#
# Contributor(s): Terry Weissman <terry@mozilla.org>
+# Dan Mosedale <dmose@mozilla.org>
# Contains some global routines used throughout the CGI scripts of Bugzilla.
$::FORM{$i} =~ s/\r$//;
}
}
-
+# check and see if a given field exists, is non-empty, and is set to a
+# legal value. assume a browser bug and abort appropriately if not.
+# if $legalsRef is not passed, just check to make sure the value exists and
+# is non-NULL
+#
+sub CheckFormField (\%$;\@) {
+ my ($formRef, # a reference to the form to check (a hash)
+ $fieldname, # the fieldname to check
+ $legalsRef # (optional) ref to a list of legal values
+ ) = @_;
+
+ if ( !defined $formRef->{$fieldname} ||
+ trim($formRef->{$fieldname}) eq "" ||
+ (defined($legalsRef) &&
+ lsearch($legalsRef, $formRef->{$fieldname})<0) ){
+
+ print "A legal $fieldname was not set; ";
+ print Param("browserbugmessage");
+ exit 0;
+ }
+}
+# check and see if a given field is defined, and abort if not
+#
+sub CheckFormFieldDefined (\%$) {
+ my ($formRef, # a reference to the form to check (a hash)
+ $fieldname, # the fieldname to check
+ ) = @_;
+
+ if ( !defined $formRef->{$fieldname} ) {
+ print "$fieldname was not defined; ";
+ print Param("browserbugmessage");
+ exit 0;
+ }
+}
+
+# check and see if a given string actually represents a positive
+# integer, and abort if not.
+#
+sub CheckPosInt($) {
+ my ($number) = @_; # the fieldname to check
+
+ if ( $number !~ /^[1-9][0-9]*$/ ) {
+ print "Received string \"$number\" when postive integer expected; ";
+ print Param("browserbugmessage");
+ exit 0;
+ }
+}
sub FormData {
my ($field) = (@_);
}
}
if (!$found && $default ne "") {
+ if ( Param("strictvaluechecks") &&
+ ($default ne $::dontchange) && ($default ne "-All-") ) {
+ print "Possible bug database corruption has been detected. " .
+ "Please send mail to " . Param("maintainer") . " with " .
+ "details of what you were doing when this message " .
+ "appeared. Thank you.\n";
+ exit 0;
+
+ } else {
$popup .= "<OPTION SELECTED>$default";
+ }
}
return $popup;
}
# Rights Reserved.
#
# Contributor(s): Terry Weissman <terry@mozilla.org>
-
+# Dan Mosedale <dmose@mozilla.org>
use diagnostics;
use strict;
print "and choose a component.\n";
exit 0
}
-
if (!defined $::FORM{'short_desc'} || trim($::FORM{'short_desc'}) eq "") {
print "You must enter a summary for this bug. Please hit the\n";
exit;
}
+if ( Param("strictvaluechecks") ) {
+ GetVersionTable();
+ CheckFormField(\%::FORM, 'reporter');
+ CheckFormField(\%::FORM, 'product', \@::legal_product);
+ CheckFormField(\%::FORM, 'version', \@{$::versions{$::FORM{'product'}}});
+ CheckFormField(\%::FORM, 'rep_platform', \@::legal_platform);
+ CheckFormField(\%::FORM, 'bug_severity', \@::legal_severity);
+ CheckFormField(\%::FORM, 'priority', \@::legal_priority);
+ CheckFormField(\%::FORM, 'op_sys', \@::legal_opsys);
+ CheckFormFieldDefined(\%::FORM, 'assigned_to');
+ CheckFormField(\%::FORM, 'bug_status', \@::legal_bug_status);
+ CheckFormFieldDefined(\%::FORM, 'bug_file_loc');
+ CheckFormField(\%::FORM, 'component',
+ \@{$::components{$::FORM{'product'}}});
+ CheckFormFieldDefined(\%::FORM, 'comment');
+}
my $forceAssignedOK = 0;
if ($::FORM{'assigned_to'} eq "") {
my @bug_fields = ("reporter", "product", "version", "rep_platform",
"bug_severity", "priority", "op_sys", "assigned_to",
- "bug_status", "bug_file_loc", "short_desc", "component",
- "status_whiteboard", "target_milestone");
+ "bug_status", "bug_file_loc", "short_desc", "component");
if (Param("useqacontact")) {
SendSQL("select initialqacontact from components where program=" .
# Rights Reserved.
#
# Contributor(s): Terry Weissman <terry@mozilla.org>
+# Dan Mosedale <dmose@mozilla.org>
use diagnostics;
use strict;
GetVersionTable();
+if ( Param("strictvaluechecks") ) {
+ CheckFormFieldDefined(\%::FORM, 'product');
+ CheckFormFieldDefined(\%::FORM, 'version');
+ CheckFormFieldDefined(\%::FORM, 'component');
+}
+
if ($::FORM{'product'} ne $::dontchange) {
+ if ( Param("strictvaluechecks") ) {
+ CheckFormField(\%::FORM, 'product', \@::legal_product);
+ }
my $prod = $::FORM{'product'};
+
+ # note that when this script is called from buglist.cgi (rather
+ # than show_bug.cgi), it's possible that the product will be changed
+ # but that the version and/or component will be set to
+ # "--dont_change--" but still happen to be correct. in this case,
+ # the if statement will incorrectly trigger anyway. this is a
+ # pretty weird case, and not terribly unreasonable behavior, but
+ # worthy of a comment, perhaps.
+ #
my $vok = lsearch($::versions{$prod}, $::FORM{'version'}) >= 0;
my $cok = lsearch($::components{$prod}, $::FORM{'component'}) >= 0;
if (!$vok || !$cok) {
my @idlist;
if (defined $::FORM{'id'}) {
+
+ # since this means that we were called from show_bug.cgi, now is a good
+ # time to do a whole bunch of error checking that can't easily happen when
+ # we've been called from buglist.cgi, because buglist.cgi only tweaks
+ # values that have been changed instead of submitting all the new values.
+ # (XXX those error checks need to happen too, but implementing them
+ # is more work in the current architecture of this script...)
+ #
+ if ( Param('strictvaluechecks') ) {
+ CheckFormField(\%::FORM, 'rep_platform', \@::legal_platform);
+ CheckFormField(\%::FORM, 'priority', \@::legal_priority);
+ CheckFormField(\%::FORM, 'bug_severity', \@::legal_severity);
+ CheckFormField(\%::FORM, 'component',
+ \@{$::components{$::FORM{'product'}}});
+ CheckFormFieldDefined(\%::FORM, 'bug_file_loc');
+ CheckFormFieldDefined(\%::FORM, 'short_desc');
+ CheckFormField(\%::FORM, 'product', \@::legal_product);
+ CheckFormField(\%::FORM, 'version',
+ \@{$::versions{$::FORM{'product'}}});
+ CheckFormField(\%::FORM, 'op_sys', \@::legal_opsys);
+ CheckFormFieldDefined(\%::FORM, 'longdesclength');
+ CheckPosInt($::FORM{'id'});
+ }
push @idlist, $::FORM{'id'};
} else {
foreach my $i (keys %::FORM) {
if ($i =~ /^id_/) {
+ if ( Param('strictvaluechecks') ) {
+ CheckPosInt(substr($i, 3));
+ }
push @idlist, substr($i, 3);
}
}
$::FORM{'who'} = $::COOKIE{'Bugzilla_login'};
}
+# the common updates to all bugs in @idlist start here
+#
print "<TITLE>Update Bug " . join(" ", @idlist) . "</TITLE>\n";
if (defined $::FORM{'id'}) {
navigation_header();
}
}
-
-foreach my $field ("rep_platform", "priority", "bug_severity", "url",
+foreach my $field ("rep_platform", "priority", "bug_severity",
"summary", "component", "bug_file_loc", "short_desc",
- "product", "version", "component", "op_sys",
+ "product", "version", "op_sys",
"target_milestone", "status_whiteboard") {
if (defined $::FORM{$field}) {
if ($::FORM{$field} ne $::dontchange) {
ConnectToDatabase();
+if ( Param('strictvaluechecks') ) {
+ CheckFormFieldDefined(\%::FORM, 'knob');
+}
SWITCH: for ($::FORM{'knob'}) {
/^none$/ && do {
last SWITCH;
/^reassign$/ && do {
ChangeStatus('NEW');
DoComma();
+ if ( Param("strictvaluechecks") ) {
+ if ( !defined$::FORM{'assigned_to'} ||
+ trim($::FORM{'assigned_to'}) eq "") {
+ print "You cannot reassign to a bug to noone. Unless you intentionally cleared out the \"Reassign bug to\" field, ";
+ print Param("browserbugmessage");
+ exit 0;
+ }
+ }
my $newid = DBNameToIdAndCheck($::FORM{'assigned_to'});
$::query .= "assigned_to = $newid";
last SWITCH;
/^duplicate$/ && do {
ChangeStatus('RESOLVED');
ChangeResolution('DUPLICATE');
+ if ( Param('strictvaluechecks') ) {
+ CheckFormFieldDefined(\%::FORM,'dup_id');
+ }
my $num = trim($::FORM{'dup_id'});
if ($num !~ /^[0-9]*$/) {
print "You must specify a bug number of which this bug is a\n";
print "duplicate. The bug has not been changed.\n";
exit;
}
- if ($::FORM{'dup_id'} == $::FORM{'id'}) {
+ if (defined($::FORM{'id'}) && $::FORM{'dup_id'} == $::FORM{'id'}) {
print "Nice try, $::FORM{'who'}. But it doesn't really make sense to mark a\n";
print "bug as a duplicate of itself, does it?\n";
exit;
}
AppendComment($::FORM{'dup_id'}, $::FORM{'who'}, "*** Bug $::FORM{'id'} has been marked as a duplicate of this bug. ***");
+ if ( Param('strictvaluechecks') ) {
+ CheckFormFieldDefined(\%::FORM,'comment');
+ }
$::FORM{'comment'} .= "\n\n*** This bug has been marked as a duplicate of $::FORM{'dup_id'} ***";
print "<TABLE BORDER=1><TD><H2>Notation added to bug $::FORM{'dup_id'}</H2>\n";
return 0;
}
-
+# this loop iterates once for each bug to be processed (eg when this script
+# is called by with multiple bugs selected from buglist.cgi instead of
+# show_bug.cgi).
+#
foreach my $id (@idlist) {
my %dependencychanged;
SendSQL("lock tables bugs write, bugs_activity write, cc write, profiles write, dependencies write, votes write");
DumpBugActivity($id, $delta_ts);
my $longdesc = GetLongDescription($id);
my $longchanged = 0;
+
if (length($longdesc) > $::FORM{'longdesclength'}) {
$longchanged = 1;
print "<P>Added text to the long description:<blockquote><pre>";
}
+ # get a snapshot of the newly set values out of the database,
+ # and then generate any necessary bug activity entries by seeing
+ # what has changed since before we wrote out the new values.
+ #
my @newvalues = SnapShotBug($id);
foreach my $col (@::log_columns) {
my $old = shift @oldvalues;
projects / thirdparty / bugzilla.git / commitdiff
