Finally fix the clang-tidy issues.

Root cause was the slightly different parsing or the Checks: line, newer version handle the single quotes differently.
Also remove two entries that are not present on older clang-tidy implementations.

diff --git a/.clang-tidy.bugs b/.clang-tidy.bugs
index 612bcf370c7804edde28a7e40e01bb6d3e30c3e5..f6499ffc38fe3bf6590adf92e9e38ab8ae073ea5 100644 (file)
--- a/.clang-tidy.bugs
+++ b/.clang-tidy.bugs
@@ -1,17 +1,18 @@
 ---
 FormatStyle: none
-HeaderFileExtensions:
-  - h
-  - hh
-  - hpp
-ImplementationFileExtensions:
-  - c
-  - cc
-  - cpp
+# Older (pre 19) versions of clang-tidy do not grok these
+# HeaderFileExtensions:
+#  - h
+#  - hh
+#  - hpp
+#ImplementationFileExtensions:
+#  - c
+#  - cc
+#  - cpp
 WarningsAsErrors: ''
 HeaderFilterRegex: ''
 Checks: |
-  'clang-diagnostic-*,clang-analyzer-*,bugprone-*,concurrency-*,-modernize-use-trailing-return-type,-readability-magic-numbers,-cppcoreguidelines-avoid-magic-numbers,-performance-avoid-endl'
+  clang-diagnostic-*,clang-analyzer-*,bugprone-*,concurrency-*,-modernize-use-trailing-return-type,-readability-magic-numbers,-cppcoreguidelines-avoid-magic-numbers,-performance-avoid-endl
 # yamllint disable rule:line-length
 CheckOptions:
   - key: bugprone-string-constructor.LargeLengthThreshold

diff --git a/.clang-tidy.full b/.clang-tidy.full
index 3c73e19b47da9fbdbe558afb02b749ecd7f0a039..ff0eb7355008333155d69d947831553986a6acec 100644 (file)
--- a/.clang-tidy.full
+++ b/.clang-tidy.full
@@ -1,17 +1,18 @@
 ---
-FormatStyle: none
-HeaderFileExtensions:
-  - h
-  - hh
-  - hpp
-ImplementationFileExtensions:
-  - c
-  - cc
-  - cpp
+FormatStyle: non
+# Older (pre 19) versions of clang-tidy do not grok these
+#HeaderFileExtensions:
+#  - h
+#  - hh
+#  - hpp
+#ImplementationFileExtensions:
+#  - c
+#  - cc
+#  - cpp
 WarningsAsErrors: ''
 HeaderFilterRegex: ''
 Checks: |
-  'clang-diagnostic-*,clang-analyzer-*,cppcoreguidelines-*,bugprone-*,concurrency-*,modernize-*,performance-*,portability-*,readability-*,-modernize-use-trailing-return-type,-readability-magic-numbers,-cppcoreguidelines-avoid-magic-numbers,-cppcoreguidelines-pro-type-union-access,-cppcoreguidelines-avoid-non-const-global-variables,-cppcoreguidelines-pro-type-vararg,-cppcoreguidelines-avoid-do-while,-cppcoreguidelines-avoid-const-or-ref-data-members,-performance-avoid-endl'
+  clang-diagnostic-*,clang-analyzer-*,cppcoreguidelines-*,bugprone-*,concurrency-*,modernize-*,performance-*,portability-*,readability-*,-modernize-use-trailing-return-type,-readability-magic-numbers,-cppcoreguidelines-avoid-magic-numbers,-cppcoreguidelines-pro-type-union-access,-cppcoreguidelines-avoid-non-const-global-variables,-cppcoreguidelines-pro-type-vararg,-cppcoreguidelines-avoid-do-while,-cppcoreguidelines-avoid-const-or-ref-data-members,-performance-avoid-endl
 # yamllint disable rule:line-length
 CheckOptions:
   - key: readability-suspicious-call-argument.PrefixSimilarAbove