libsoup-2.4: deprecate Buffer.new and MessageBody.append

These functions require the user to correctly specify a Soup.MemoryUse
argument, but that's easy to get wrong without understanding how the
memory is managed.  Alternatives for these functions which will always
transfer ownership of the memory have been in place since 2.32, so
from now on we will emit a warning when someone tries to use the old
versions.

diff --git a/vapi/libsoup-2.4.vapi b/vapi/libsoup-2.4.vapi
index 78c0dbe89dd89bea1fe98f5368afe11ad67fb0a1..6392488ae5502f17e1775ead7c6bc95e6565b2d2 100644 (file)
--- a/vapi/libsoup-2.4.vapi
+++ b/vapi/libsoup-2.4.vapi
@@ -207,6 +207,7 @@ namespace Soup {
                public uint8[] data;
                public size_t length;
                [CCode (has_construct_function = false)]
+               [Deprecated (replacement = "Buffer.take", since = "2.32")]
                public Buffer (Soup.MemoryUse use, [CCode (array_length_cname = "length", array_length_pos = 2.1, array_length_type = "gsize", type = "gconstpointer")] uint8[] data);
                public Soup.Buffer copy ();
                public void free ();
@@ -465,6 +466,7 @@ namespace Soup {
                public int64 length;
                [CCode (has_construct_function = false)]
                public MessageBody ();
+               [Deprecated (replacement = "MessageBody.append_take", since = "2.32")]
                public void append (Soup.MemoryUse use, [CCode (array_length_cname = "length", array_length_pos = 2.1, array_length_type = "gsize")] uint8[] data);
                public void append_buffer (Soup.Buffer buffer);
                public void append_take ([CCode (array_length_cname = "length", array_length_pos = 1.1, array_length_type = "gsize")] owned uint8[] data);

diff --git a/vapi/metadata/Soup-2.4.metadata b/vapi/metadata/Soup-2.4.metadata
index 7f63bb81526a5bad9a5fc621280bea8ee5039fb9..16a9c48d6c7c3a01dc599f7389f6c8db783ea2b0 100644 (file)
--- a/vapi/metadata/Soup-2.4.metadata
+++ b/vapi/metadata/Soup-2.4.metadata
@@ -86,3 +86,9 @@ xmlrpc_request_new sentinel="G_TYPE_INVALID"
 xmlrpc_set_fault printf_format
 xmlrpc_set_response sentinel="G_TYPE_INVALID"
 xmlrpc_build_fault printf_format
+
+// Simplify memory management
+Buffer
+  .new deprecated_since="2.32" replacement="Buffer.take"
+MessageBody
+  .append deprecated_since="2.32" replacement="MessageBody.append_take"
\ No newline at end of file