]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
conf: add cpu check attribute to ABI check
authorNikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
Wed, 24 Apr 2019 09:51:18 +0000 (12:51 +0300)
committerNikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
Thu, 25 Apr 2019 07:02:23 +0000 (10:02 +0300)
Different check values are not ABI compatible. For example
if on migration we change 'full' to 'partial' then guest cpu
on destination can be different.

Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
src/conf/cpu_conf.c

index 33c8b99e495dec2ad7106dd63bf86c9953cdb53b..bd2beab33eee1951016659c6c171b76f39d16a2f 100644 (file)
@@ -894,6 +894,13 @@ virCPUDefIsEqual(virCPUDefPtr src,
         goto cleanup;
     }
 
+    if (src->check != dst->check) {
+        MISMATCH(_("Target CPU check %s does not match source %s"),
+                 virCPUCheckTypeToString(dst->check),
+                 virCPUCheckTypeToString(src->check));
+        goto cleanup;
+    }
+
     if (src->arch != dst->arch) {
         MISMATCH(_("Target CPU arch %s does not match source %s"),
                  virArchToString(dst->arch),