]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
media: qcom: camss: move SM8250 regulators from CSID to CSIPHY subdevice
authorVladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
Thu, 26 Sep 2024 21:19:57 +0000 (00:19 +0300)
committerHans Verkuil <hverkuil-cisco@xs4all.nl>
Sat, 12 Oct 2024 17:09:05 +0000 (19:09 +0200)
On Qualcomm SM8250 SoC there are two sets of regulators, and each of
both sets is specific to six CSIPHY IPs. At the moment there is no
proper split of two "combined" regulators with quite arbitrary selected
names in the driver or platform CAMSS device tree node, however for sake
of clarity and better hardware description it makes sense to move the
currently existing regulator resources from all CSID subdevices to all
CSIPHY subdevices.

Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
drivers/media/platform/qcom/camss/camss.c

index 542c2fdc5d5c0e1835a4ddd2c15aba5af10971af..fabe034081ed0a7c0e0fcd8bc76c4eb396cb0067 100644 (file)
@@ -837,7 +837,7 @@ static const struct camss_subdev_resources vfe_res_845[] = {
 static const struct camss_subdev_resources csiphy_res_8250[] = {
        /* CSIPHY0 */
        {
-               .regulators = {},
+               .regulators = { "vdda-phy", "vdda-pll" },
                .clock = { "csiphy0", "csiphy0_timer" },
                .clock_rate = { { 400000000 },
                                { 300000000 } },
@@ -850,7 +850,7 @@ static const struct camss_subdev_resources csiphy_res_8250[] = {
        },
        /* CSIPHY1 */
        {
-               .regulators = {},
+               .regulators = { "vdda-phy", "vdda-pll" },
                .clock = { "csiphy1", "csiphy1_timer" },
                .clock_rate = { { 400000000 },
                                { 300000000 } },
@@ -863,7 +863,7 @@ static const struct camss_subdev_resources csiphy_res_8250[] = {
        },
        /* CSIPHY2 */
        {
-               .regulators = {},
+               .regulators = { "vdda-phy", "vdda-pll" },
                .clock = { "csiphy2", "csiphy2_timer" },
                .clock_rate = { { 400000000 },
                                { 300000000 } },
@@ -876,7 +876,7 @@ static const struct camss_subdev_resources csiphy_res_8250[] = {
        },
        /* CSIPHY3 */
        {
-               .regulators = {},
+               .regulators = { "vdda-phy", "vdda-pll" },
                .clock = { "csiphy3", "csiphy3_timer" },
                .clock_rate = { { 400000000 },
                                { 300000000 } },
@@ -889,7 +889,7 @@ static const struct camss_subdev_resources csiphy_res_8250[] = {
        },
        /* CSIPHY4 */
        {
-               .regulators = {},
+               .regulators = { "vdda-phy", "vdda-pll" },
                .clock = { "csiphy4", "csiphy4_timer" },
                .clock_rate = { { 400000000 },
                                { 300000000 } },
@@ -902,7 +902,7 @@ static const struct camss_subdev_resources csiphy_res_8250[] = {
        },
        /* CSIPHY5 */
        {
-               .regulators = {},
+               .regulators = { "vdda-phy", "vdda-pll" },
                .clock = { "csiphy5", "csiphy5_timer" },
                .clock_rate = { { 400000000 },
                                { 300000000 } },
@@ -918,7 +918,7 @@ static const struct camss_subdev_resources csiphy_res_8250[] = {
 static const struct camss_subdev_resources csid_res_8250[] = {
        /* CSID0 */
        {
-               .regulators = { "vdda-phy", "vdda-pll" },
+               .regulators = {},
                .clock = { "vfe0_csid", "vfe0_cphy_rx", "vfe0", "vfe0_areg", "vfe0_ahb" },
                .clock_rate = { { 400000000 },
                                { 400000000 },
@@ -935,7 +935,7 @@ static const struct camss_subdev_resources csid_res_8250[] = {
        },
        /* CSID1 */
        {
-               .regulators = { "vdda-phy", "vdda-pll" },
+               .regulators = {},
                .clock = { "vfe1_csid", "vfe1_cphy_rx", "vfe1", "vfe1_areg", "vfe1_ahb" },
                .clock_rate = { { 400000000 },
                                { 400000000 },
@@ -952,7 +952,7 @@ static const struct camss_subdev_resources csid_res_8250[] = {
        },
        /* CSID2 */
        {
-               .regulators = { "vdda-phy", "vdda-pll" },
+               .regulators = {},
                .clock = { "vfe_lite_csid", "vfe_lite_cphy_rx", "vfe_lite",  "vfe_lite_ahb" },
                .clock_rate = { { 400000000 },
                                { 400000000 },
@@ -969,7 +969,7 @@ static const struct camss_subdev_resources csid_res_8250[] = {
        },
        /* CSID3 */
        {
-               .regulators = { "vdda-phy", "vdda-pll" },
+               .regulators = {},
                .clock = { "vfe_lite_csid", "vfe_lite_cphy_rx", "vfe_lite",  "vfe_lite_ahb" },
                .clock_rate = { { 400000000 },
                                { 400000000 },