]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
libsmb: Eliminate a reader of cli->raw_status
authorVolker Lendecke <vl@samba.org>
Sat, 23 Sep 2023 01:47:21 +0000 (18:47 -0700)
committerJeremy Allison <jra@samba.org>
Mon, 25 Sep 2023 19:01:34 +0000 (19:01 +0000)
At some point we should get rid of cli->raw_status.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
source3/libsmb/cli_smb2_fnum.c

index 355933122832e85ba3c8c6a4cda2d083a5abeeb0..d5a167f8dd0e4a60f7daad11c4db77980c7b9ad1 100644 (file)
@@ -2516,6 +2516,7 @@ NTSTATUS cli_smb2_setattrE(struct cli_state *cli,
 {
        uint8_t inbuf_store[40];
        DATA_BLOB inbuf = data_blob_null;
+       NTSTATUS status;
 
        if (smbXcli_conn_has_async_calls(cli->conn)) {
                /*
@@ -2542,15 +2543,15 @@ NTSTATUS cli_smb2_setattrE(struct cli_state *cli,
                put_long_date((char *)inbuf.data + 16, write_time);
        }
 
-       cli->raw_status = cli_smb2_set_info_fnum(
-               cli,
-               fnum,
-               1,              /* in_info_type */
-               SMB_FILE_BASIC_INFORMATION - 1000, /* in_file_info_class */
-               &inbuf,            /* in_input_buffer */
-               0);                /* in_additional_info */
-
-       return cli->raw_status;
+       status = cli_smb2_set_info_fnum(cli,
+                                       fnum,
+                                       1, /* in_info_type */
+                                       SMB_FILE_BASIC_INFORMATION -
+                                               1000, /* in_file_info_class */
+                                       &inbuf,       /* in_input_buffer */
+                                       0);           /* in_additional_info */
+       cli->raw_status = status;
+       return status;
 }
 
 /***************************************************************