]> git.ipfire.org Git - thirdparty/openwrt.git/commitdiff
mediatek: filogic: mt7986: fix SPI driving for NAND and increase to 52MHz on ZyXEL... 18813/head
authorSky Huang <SkyLake.Huang@mediatek.com>
Fri, 16 May 2025 10:45:02 +0000 (18:45 +0800)
committerHauke Mehrtens <hauke@hauke-m.de>
Sun, 13 Jul 2025 15:04:06 +0000 (17:04 +0200)
8mA driving will cause overshoot issue on SPI NAND. Change it to 4mA.
- Reference:
https://git01.mediatek.com/plugins/gitiles/openwrt/feeds/mtk-openwrt-feeds/+/003744197aa3a587828b4330ab1112ebdb9e840a

On Linux mainline (mt7986.dtsi), spi's source clock is: clocks = <&topckgen CLK_TOP_MPLL_D2>, which is
208MHz. Usable clock division will be:
- 208/4=52MHz
- 208/6~=35MHz
- 208/8=26MHz
and so on

If we specify 50MHz for spi-max-frequency, it will actually run under about 35MHz. Most SPI NAND & NOR
flashes are capable of running with more than 52MHz, include Micorn MT29F4G01ABAFDWB on ZyXEL EX5601.
[Ref: #18752] To reach highest performance on mt7986, use spi-max-frequency = <520000000>. Basically,
this setting should work on all mt7986 PCBs since most mt7986 boards follow reference design. However,
other boards needs further test to guarantee stability.

Signed-off-by: Sky Huang <SkyLake.Huang@mediatek.com>
Tested-by: Aleksander Jan Bajkowski <olek2@wp.pl>
Link: https://github.com/openwrt/openwrt/pull/18813
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
target/linux/mediatek/dts/mt7986a-zyxel-ex5601-t0-common.dtsi

index f714509f50303a218f6239be226ded9b07f9015a..b68f386e8bcf83c450f31ccf4df77506cfde8764 100644 (file)
                 #size-cells = <1>;
                 compatible = "spi-nand";
                 reg = <1>;
-                spi-max-frequency = <50000000>;
+                spi-max-frequency = <52000000>;
                 spi-tx-bus-width = <4>;
                 spi-rx-bus-width = <4>;
 
                };
                conf-pu {
                        pins = "SPI2_CS", "SPI2_HOLD", "SPI2_WP";
-                       drive-strength = <8>;
+                       drive-strength = <4>;
                        mediatek,pull-up-adv = <0>;     /* bias-disable */
                };
                conf-pd {
                        pins = "SPI2_CLK", "SPI2_MOSI", "SPI2_MISO";
-                       drive-strength = <8>;
+                       drive-strength = <4>;
                        mediatek,pull-down-adv = <0>;   /* bias-disable */
                };
        };