]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
qed: Remove unused qed_print_mcp_trace_*
authorDr. David Alan Gilbert <linux@treblig.org>
Mon, 14 Apr 2025 00:52:46 +0000 (01:52 +0100)
committerJakub Kicinski <kuba@kernel.org>
Tue, 15 Apr 2025 15:26:28 +0000 (08:26 -0700)
While most of the trace code is reachable by other routes
(I think mostly via the qed_features_lookup[] array), there
are a couple of unused wrappers.

qed_print_mcp_trace_line() and qed_print_mcp_trace_results_cont()
were added in 2018 as part of
commit a3f723079df8 ("qed*: Utilize FW 8.37.7.0")
but have remained unused.

Remove them.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Link: https://patch.msgid.link/20250414005247.341243-5-linux@treblig.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/qlogic/qed/qed_dbg_hsi.h
drivers/net/ethernet/qlogic/qed/qed_debug.c

index f6cd1b3efdfdf4537f352b7fb36c94ea6856efeb..27e91d0d39f8cdc257c2f27767d8082914d6c6ad 100644 (file)
@@ -1304,37 +1304,6 @@ enum dbg_status qed_print_mcp_trace_results(struct qed_hwfn *p_hwfn,
                                            u32 num_dumped_dwords,
                                            char *results_buf);
 
-/**
- * qed_print_mcp_trace_results_cont(): Prints MCP Trace results, and
- * keeps the MCP trace meta data allocated, to support continuous MCP Trace
- * parsing. After the continuous parsing ends, mcp_trace_free_meta_data should
- * be called to free the meta data.
- *
- * @p_hwfn: HW device data.
- * @dump_buf: MVP trace dump buffer, starting from the header.
- * @results_buf: Buffer for printing the mcp trace results.
- *
- * Return: Error if the parsing fails, ok otherwise.
- */
-enum dbg_status qed_print_mcp_trace_results_cont(struct qed_hwfn *p_hwfn,
-                                                u32 *dump_buf,
-                                                char *results_buf);
-
-/**
- * qed_print_mcp_trace_line(): Prints MCP Trace results for a single line
- *
- * @p_hwfn: HW device data.
- * @dump_buf: MCP trace dump buffer, starting from the header.
- * @num_dumped_bytes: Number of bytes that were dumped.
- * @results_buf: Buffer for printing the mcp trace results.
- *
- * Return: Error if the parsing fails, ok otherwise.
- */
-enum dbg_status qed_print_mcp_trace_line(struct qed_hwfn *p_hwfn,
-                                        u8 *dump_buf,
-                                        u32 num_dumped_bytes,
-                                        char *results_buf);
-
 /**
  * qed_mcp_trace_free_meta_data(): Frees the MCP Trace meta data.
  * Should be called after continuous MCP Trace parsing.
index 464a72afb758946621aebe62252ed25ec7556fae..9c3d3dd2f84753100d3c639505677bd53e3ca543 100644 (file)
@@ -7614,31 +7614,6 @@ enum dbg_status qed_print_mcp_trace_results(struct qed_hwfn *p_hwfn,
                                        results_buf, &parsed_buf_size, true);
 }
 
-enum dbg_status qed_print_mcp_trace_results_cont(struct qed_hwfn *p_hwfn,
-                                                u32 *dump_buf,
-                                                char *results_buf)
-{
-       u32 parsed_buf_size;
-
-       return qed_parse_mcp_trace_dump(p_hwfn, dump_buf, results_buf,
-                                       &parsed_buf_size, false);
-}
-
-enum dbg_status qed_print_mcp_trace_line(struct qed_hwfn *p_hwfn,
-                                        u8 *dump_buf,
-                                        u32 num_dumped_bytes,
-                                        char *results_buf)
-{
-       u32 parsed_results_bytes;
-
-       return qed_parse_mcp_trace_buf(p_hwfn,
-                                      dump_buf,
-                                      num_dumped_bytes,
-                                      0,
-                                      num_dumped_bytes,
-                                      results_buf, &parsed_results_bytes);
-}
-
 /* Frees the specified MCP Trace meta data */
 void qed_mcp_trace_free_meta_data(struct qed_hwfn *p_hwfn)
 {