]> git.ipfire.org Git - thirdparty/nftables.git/commitdiff
evaluate: don't needlessly clear full string buffer in stmt_evaluate_log_prefix()
authorThomas Haller <thaller@redhat.com>
Tue, 29 Aug 2023 12:53:35 +0000 (14:53 +0200)
committerPablo Neira Ayuso <pablo@netfilter.org>
Tue, 29 Aug 2023 17:56:03 +0000 (19:56 +0200)
Signed-off-by: Thomas Haller <thaller@redhat.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
src/evaluate.c

index 83c4b045818031e775561307b860f75c2709277e..c13be824950f09be24ab666b93be34f6c5cc593d 100644 (file)
@@ -4125,7 +4125,8 @@ static int stmt_evaluate_queue(struct eval_ctx *ctx, struct stmt *stmt)
 
 static int stmt_evaluate_log_prefix(struct eval_ctx *ctx, struct stmt *stmt)
 {
-       char prefix[NF_LOG_PREFIXLEN] = {}, tmp[NF_LOG_PREFIXLEN] = {};
+       char tmp[NF_LOG_PREFIXLEN] = {};
+       char prefix[NF_LOG_PREFIXLEN];
        size_t len = sizeof(prefix);
        size_t offset = 0;
        struct expr *expr;
@@ -4133,6 +4134,8 @@ static int stmt_evaluate_log_prefix(struct eval_ctx *ctx, struct stmt *stmt)
        if (stmt->log.prefix->etype != EXPR_LIST)
                return 0;
 
+       prefix[0] = '\0';
+
        list_for_each_entry(expr, &stmt->log.prefix->expressions, list) {
                int ret;