lib: Slightly tune cp_smb_filename_nostream()

Don't talloc_strdup() the stream_name, just to free it again.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

diff --git a/source3/lib/filename_util.c b/source3/lib/filename_util.c
index 120d2ecc4bcacb9810ff2b37ca5d796f3a866af3..f97c4310162318407baa0c128eeeb8948301df7f 100644 (file)
--- a/source3/lib/filename_util.c
+++ b/source3/lib/filename_util.c
@@ -80,12 +80,12 @@ struct smb_filename *synthetic_smb_fname(TALLOC_CTX *mem_ctx,
 struct smb_filename *cp_smb_filename_nostream(TALLOC_CTX *mem_ctx,
                                        const struct smb_filename *smb_fname_in)
 {
-       struct smb_filename *smb_fname = cp_smb_filename(mem_ctx,
-                                                       smb_fname_in);
-       if (smb_fname == NULL) {
-               return NULL;
-       }
-       TALLOC_FREE(smb_fname->stream_name);
+       struct smb_filename smb_fname_loc = *smb_fname_in;
+       struct smb_filename *smb_fname = NULL;
+
+       smb_fname_loc.stream_name = NULL;
+
+       smb_fname = cp_smb_filename(mem_ctx, &smb_fname_loc);
        return smb_fname;
 }