]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
misc: cb710: Fix a NULL vs IS_ERR() check in probe()
authorDan Carpenter <dan.carpenter@linaro.org>
Wed, 29 Oct 2025 13:13:56 +0000 (16:13 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 26 Nov 2025 14:09:34 +0000 (15:09 +0100)
The pcim_iomap_region() function never returns NULL, it returns error
pointers.  Update the checking to match.

Fixes: b91c13534a63 ("misc: cb710: Replace deprecated PCI functions")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Link: https://patch.msgid.link/aQITFDPyuzjNN4GN@stanley.mountain
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/cb710/core.c

index a1e6ba62c298063d0684b6ac938dcce7720574d5..2dd212f04fed2aed5a6907609a0ee4acda119da9 100644 (file)
@@ -226,8 +226,8 @@ static int cb710_probe(struct pci_dev *pdev,
        spin_lock_init(&chip->irq_lock);
        chip->pdev = pdev;
        chip->iobase = pcim_iomap_region(pdev, 0, KBUILD_MODNAME);
-       if (!chip->iobase)
-               return -ENOMEM;
+       if (IS_ERR(chip->iobase))
+               return PTR_ERR(chip->iobase);
 
        pci_set_drvdata(pdev, chip);