]> git.ipfire.org Git - thirdparty/bugzilla.git/commitdiff
Bug 995988: can_edit_product() can throw warnings if SUM() returns NULL
authorGervase Markham <gerv@mozilla.org>
Wed, 16 Apr 2014 19:26:49 +0000 (21:26 +0200)
committerFrédéric Buclin <LpSolit@gmail.com>
Wed, 16 Apr 2014 19:26:49 +0000 (21:26 +0200)
r=LpSolit a=justdave

Bugzilla/User.pm

index 1f0acee3d658d7f7f7323043cf6b682761750631..5cebe728b716757a9fdfed129ec6305fe28027a5 100644 (file)
@@ -906,7 +906,7 @@ sub can_edit_product {
                            CASE WHEN canedit = 1 AND group_id IN ($groups) THEN 1 ELSE 0 END AS cnt_group_member
                     FROM group_control_map
                     WHERE product_id = $prod_id) AS p");
-        return ($cnt_can_edit == 0 or $cnt_group_member > 0);
+        return (!$cnt_can_edit or $cnt_group_member);
     }
     else {
         # For and-groups, a user needs to be in all canedit groups. Therefore