]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemuBlockBitmapsHandleCommitStart: Fix allocation of string list
authorPeter Krempa <pkrempa@redhat.com>
Tue, 17 Mar 2020 14:10:23 +0000 (15:10 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Tue, 17 Mar 2020 15:32:12 +0000 (16:32 +0100)
Allocate space also for the terminating NULL.

Reported-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Tested-by: Daniel P. Berrangé <berrange@redhat.com>
src/qemu/qemu_block.c

index cc2edff5e0cdc8a02dcbb4a0eed3eefe693489f1..115682c39d95e5020681fe96b141567b08aff79c 100644 (file)
@@ -3021,7 +3021,7 @@ qemuBlockBitmapsHandleCommitStart(virStorageSourcePtr topsrc,
     if (!(entry = virHashLookup(blockNamedNodeData, basesrc->nodeformat)))
         return 0;
 
-    bitmaplist = g_new0(char *, entry->nbitmaps);
+    bitmaplist = g_new0(char *, entry->nbitmaps + 1);
 
     for (i = 0; i < entry->nbitmaps; i++) {
         qemuBlockNamedNodeDataBitmapPtr bitmap = entry->bitmaps[i];