]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
thunderbolt: Log path activation failures without WARN backtraces
authorChia-Lin Kao (AceLan) <acelan.kao@canonical.com>
Fri, 2 Jan 2026 03:19:05 +0000 (11:19 +0800)
committerMika Westerberg <mika.westerberg@linux.intel.com>
Mon, 5 Jan 2026 11:14:43 +0000 (12:14 +0100)
tb_path_activate() currently logs failures with tb_WARN(), which triggers
a stack trace. Transient conditions such as lane bonding or Type-C link
hiccups can fail path activation briefly, and the resulting backtraces are
noisy without aiding diagnosis.

Switch to tb_warn() for all path activation failures. The error code is
already returned to callers, and the warning still shows the message
without the backtrace.

Signed-off-by: Chia-Lin Kao (AceLan) <acelan.kao@canonical.com>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
drivers/thunderbolt/path.c

index f9b11dadfbdd59e0b1ec5727af35b1314583e40a..50659bd55d7b50bbf059efa00c09df8b738f67a8 100644 (file)
@@ -586,7 +586,7 @@ int tb_path_activate(struct tb_path *path)
        tb_dbg(path->tb, "%s path activation complete\n", path->name);
        return 0;
 err:
-       tb_WARN(path->tb, "%s path activation failed\n", path->name);
+       tb_warn(path->tb, "%s path activation failed: %d\n", path->name, res);
        return res;
 }